chore(test): override curlinfo to report urlx capabilities (unskip test 777)#130
Merged
jonwiggins merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
…st 777) curl's curlinfo binary reflects curl's build configuration, not urlx's. When curl is built without ssl-sessions support, the test harness skips test 777 even though urlx supports ssl-sessions. Add a curlinfo-urlx wrapper script that: - When a real curlinfo exists, runs it and patches ssl-sessions to ON - When no curlinfo exists, outputs a complete feature list matching urlx's capabilities Update run-curl-tests.sh to install the wrapper in place of curl's curlinfo binary, following the same pattern used for libtests-shim. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/curlinfo-urlxwrapper that overrides curl'scurlinfobinary to report urlx's actual feature capabilitiesscripts/run-curl-tests.shto install the curlinfo wrapper, following the same pattern as the existing libtests-shim--ssl-sessions with weird sessions in file) which was skipped because curl's curlinfo reportedssl-sessions: OFFeven though urlx supports ssl-sessionsCloses #124
How it works
curl's test harness (
runtests.pl) runs thecurlinfobinary to detect enabled features. Since this binary comes from curl's own build, it reflects curl's build configuration — not urlx's capabilities. Test 777 requires thessl-sessionsfeature, which urlx supports but curl wasn't built with.The
curlinfo-urlxwrapper handles two cases:ssl-sessions: OFF→ssl-sessions: ONvia sedThe wrapper is extensible — additional urlx-specific feature overrides can be added to the
URLX_FEATURES_ONarray.Test plan
scripts/curlinfo-urlxoutputsssl-sessions: ONin both modes (with and without a real curlinfo)scripts/run-curl-tests.sh 777and verify test 777 passes instead of being skipped🤖 Generated with Claude Code