chore(test): unskip test 777 — override curlinfo for ssl-sessions#129
Closed
jonwiggins wants to merge 1 commit intomainfrom
Closed
chore(test): unskip test 777 — override curlinfo for ssl-sessions#129jonwiggins wants to merge 1 commit intomainfrom
jonwiggins wants to merge 1 commit intomainfrom
Conversation
The curl test harness runs `curlinfo` to detect compiled-in features. Since that binary comes from curl's build (not urlx), it reports `ssl-sessions: OFF` even though urlx implements ssl-sessions (#73). This causes test 777 to be skipped unnecessarily. Add a `curlinfo-wrapper` script that intercepts the curlinfo output and overrides `ssl-sessions` to ON to reflect urlx's actual capabilities. The wrapper is installed by `run-curl-tests.sh` using the same pattern as the existing libtests shim. When a real curlinfo binary exists, the wrapper runs it and patches the output. When no binary exists, it outputs a static feature list matching urlx's capabilities. Closes #124 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/curlinfo-wrapperto override curl'scurlinfobinary so the test harness detects urlx's actual feature setscripts/run-curl-tests.shto install the wrapper before running tests--ssl-sessions with weird sessions in file) which was previously skipped because curl's owncurlinforeportsssl-sessions: OFFProblem
The curl test harness runs a
curlinfobinary to detect compiled-in features. Since this binary comes from curl's own build (not urlx), it reportsssl-sessions: OFF— even though urlx fully implements ssl-sessions (closed in #73). This causes test 777 to be unnecessarily skipped.Solution
The
curlinfo-wrapperscript intercepts curlinfo output and overridesssl-sessionstoON. Two modes:ssl-sessions: OFF→ONThe wrapper is installed by
run-curl-tests.shusing the same save-original-and-replace pattern as the existinglibtestsshim.Test plan
curlinfo-wrapperoutputsssl-sessions: ONin both modes (static fallback and override)bash -nsyntax checkcargo checkstill passesCloses #124
🤖 Generated with Claude Code