chore(test): unskip test 777 — ssl-sessions feature already implemented#128
Closed
jonwiggins wants to merge 1 commit intomainfrom
Closed
chore(test): unskip test 777 — ssl-sessions feature already implemented#128jonwiggins wants to merge 1 commit intomainfrom
jonwiggins wants to merge 1 commit intomainfrom
Conversation
The curl test harness uses the curlinfo binary to detect compile-time features. Since curlinfo comes from curl's build, it reports curl's configuration — not urlx's capabilities. This caused test 777 (--ssl-sessions with weird sessions in file) to be skipped because curl wasn't built with USE_SSLS_EXPORT, even though urlx fully supports ssl-sessions (closed in #73). Add scripts/urlx-curlinfo that: - When the original curlinfo exists, wraps it and overrides ssl-sessions from OFF to ON - When no original curlinfo exists, outputs a standalone feature list reflecting urlx's actual capabilities Modify scripts/run-curl-tests.sh to install the urlx-curlinfo wrapper at the expected path before running the test suite, following the same pattern used for the libtests shim. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/urlx-curlinfowrapper that overrides curl'scurlinfobinary to report urlx's actual feature setssl-sessions: OFF→ssl-sessions: ONscripts/run-curl-tests.shto install the wrapper atvendor/curl-build/src/curlinfobefore running the test suite (same pattern as the existing libtests shim)This enables curl test 777 (
--ssl-sessions with weird sessions in file) to run, which was previously skipped because curl's curlinfo binary reportedssl-sessions: OFFeven though urlx fully supports ssl-sessions (closed in #73).Closes #124
Test plan
scripts/urlx-curlinfooutputs correct format withssl-sessions: ONscripts/run-curl-tests.sh 777🤖 Generated with Claude Code