fix(http): reset is_ntlm_probe after Type 3 auth to prevent duplicate request#127
Closed
jonwiggins wants to merge 1 commit intomainfrom
Closed
fix(http): reset is_ntlm_probe after Type 3 auth to prevent duplicate request#127jonwiggins wants to merge 1 commit intomainfrom
jonwiggins wants to merge 1 commit intomainfrom
Conversation
… request The is_ntlm_probe flag was set to true at the start of an NTLM exchange but never reset after the Type 3 authentication completed. This caused the probe-retry logic to sometimes fire on the already-successful 200 response, sending a spurious third request that broke protocol traces. Fixes #121 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_ntlm_probeflag tofalseafter NTLM Type 3 authentication completes successfully, preventing the probe-retry logic from sending a spurious third HTTP requestis_ntlm_probe && status != 401) could fire on the already-successful 200 responseFixes #121
Test plan
cargo testpasses (all 2,655+ tests)cargo clippyclean./scripts/run-curl-tests.sh 150passes consistently (was ~40% failure rate)🤖 Generated with Claude Code