fix(http): don't reuse connection when --fail skips body (test 1328)#125
Closed
jonwiggins wants to merge 1 commit intomainfrom
Closed
fix(http): don't reuse connection when --fail skips body (test 1328)#125jonwiggins wants to merge 1 commit intomainfrom
jonwiggins wants to merge 1 commit intomainfrom
Conversation
When --fail triggers on a 4xx response, the body read is skipped but the connection was being returned to the pool with unread body data still on the socket. When URL globbing reuses that pooled connection for the next URL, the HTTP parser reads stale body data instead of fresh response headers, causing a hang. Fix: mark the connection as non-reusable when fail_skip is true and the response has body framing (Content-Length or chunked TE). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--failtriggers on a 4xx response, the body read is skipped but the connection was returned to the pool with unread data still on the socketfail_skipis true and the response has body framing (Content-Length or chunked Transfer-Encoding)Fixes #122
Test plan
🤖 Generated with Claude Code