Skip to content

[codex] Implement guided init provider onboarding#131

Merged
jonit-dev merged 4 commits into
masterfrom
night-watch/130-guided-init-onboarding
Jun 11, 2026
Merged

[codex] Implement guided init provider onboarding#131
jonit-dev merged 4 commits into
masterfrom
night-watch/130-guided-init-onboarding

Conversation

@jonit-dev

Copy link
Copy Markdown
Owner

Summary

  • Implements guided init provider auto-selection with deterministic Codex-over-Claude precedence.
  • Accepts all built-in provider preset IDs while checking the underlying CLI command.
  • Adds --yes plus custom provider flags that write providerPresets for non-interactive setup.
  • Adds a TTY-only project review/confirmation before writes and keeps non-TTY/--yes runs prompt-free.

Closes #130

Validation

  • yarn workspace @jonit-dev/night-watch-cli build
  • yarn vitest packages/cli/src/__tests__/commands/init.test.ts --run
  • yarn verify
  • yarn eslint packages/cli/src/commands/init.ts packages/cli/src/__tests__/commands/init.test.ts --quiet
  • git diff --check

Notes

  • Full yarn lint --quiet still reports existing unrelated lint errors in packages/cli/src/commands/dashboard/tab-schedules.ts and packages/cli/src/commands/manager.ts.

@jonit-dev jonit-dev marked this pull request as ready for review June 11, 2026 00:47
@jonit-dev

Copy link
Copy Markdown
Owner Author

Self-review / verification

Reviewed PR #131 against issue #130 and the guided-init PRD.

What I checked:

  • Diff scope is limited to init onboarding/tests plus two lint cleanups: packages/cli/src/commands/init.ts, packages/cli/src/__tests__/commands/init.test.ts, tab-schedules.ts, manager.ts.
  • Provider flow preserves deterministic non-interactive behavior and adds TTY-only override after auto-selecting by precedence.
  • Job selection writes existing config fields consumed by install/status: executor/reviewer/QA/audit/analytics/slicer/pr-resolver/manager/merger, including schedule overrides and autoMerge when merger is enabled.
  • Notification flow uses existing webhook config + validator, keeps setup optional, and masks Telegram chat IDs in summaries.
  • No raw secrets are printed in final notification summaries; webhook secrets are only written to config as requested by the existing model.

Verification run locally on head 56971f0:

  • yarn vitest packages/cli/src/__tests__/commands/init.test.ts --run → 44 passed
  • yarn lint → 0 errors, existing warnings only
  • yarn verify → passed
  • git diff --check → passed

GitHub checks on the same head:

  • verify → success
  • lint → success
  • test → success
  • core-flow-smoke → success
  • review → failing due to repo/action infrastructure (jonit-dev/openrouter-github-action@main missing dist/index.js), not PR code.

Verdict: merge-ready from code/test perspective. The failed AI review check is infrastructure noise, not a product failure.

@jonit-dev jonit-dev merged commit 9471205 into master Jun 11, 2026
4 of 5 checks passed
@jonit-dev jonit-dev deleted the night-watch/130-guided-init-onboarding branch June 11, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guided Init Onboarding

1 participant