fix (partial) mixed_dml test failures #938#965
Open
manuerwin wants to merge 1 commit intojongpie:mainfrom
Open
fix (partial) mixed_dml test failures #938#965manuerwin wants to merge 1 commit intojongpie:mainfrom
manuerwin wants to merge 1 commit intojongpie:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #938 as I've been experiencing MIXED_DML test failures in LogHandler_Tests in both it_should_set_owner_when_default_configured_with_user_id and it_should_set_owner_when_default_configured_with_username.
History: package was originally installed for "all users" by mistake, and since then 4 tests have been failing, I worked out I needed to remove the three Nebula custom permissions and reinstall the package ("admins only") which solved 2 of the 4 errors, however still getting mixed_dml so seeking to solve by using system.runas() which allows for mixed dml in tests.
Hopefully that aligns with the intent of these two tests 🤞