Fix: Chunked regex with overlapping Matcher for boundary-safe data masking#959
Open
anthonygiuliano wants to merge 1 commit intojongpie:mainfrom
Open
Conversation
…jongpie#639) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #639 —
System.LimitException: Regex too complicatedwhenapplyDataMaskRulesprocesses long strings (~35K+ chars).The existing chunking logic in
applyDataMaskRuleToLongLinehad three correctness issues that this PR addresses:expandReplacement: The old iterativeString.replace('$' + i, groups[i])reinterpreted$Npatterns inside captured group values (e.g., if group 1 capturedPRICE:$3, the$3would be replaced with group 3's value). The new implementation scans the replacement template left-to-right, only interpreting$Nin the template itself — matching Java'sMatcher.appendReplacementbehavior.Test plan
start < posbranch)$Ntokens inside captured group values are preserved literally (not re-expanded as group references)🤖 Generated with Claude Code