Add MCP Apps UI support with SDK dashboard#413
Merged
jongalloway merged 6 commits intomainfrom Mar 21, 2026
Merged
Conversation
Implement MCP Apps (SEP-1865) support for the DotnetSdk tool, rendering an interactive HTML dashboard inline in VS Code chat. - Add McpAppsResources with ui:// resource returning themed HTML dashboard - Add both modern nested and legacy flat McpMeta keys on DotnetSdk tool (VS Code requires the legacy 'ui/resourceUri' flat key) - Register McpAppsResources in Program.cs - Add wire format tests validating both _meta key formats - Add doc/mcp-apps.md implementation guide
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Owner
Author
|
@copilot address comments |
… catch clause Co-authored-by: jongalloway <68539+jongalloway@users.noreply.github.com> Agent-Logs-Url: https://github.com/jongalloway/dotnet-mcp/sessions/09222802-7404-459d-a12c-088bc75feba3
Contributor
Addressed both GitHub Advanced Security alerts in
CodeQL now reports 0 alerts. |
Comment on lines
+615
to
+619
| catch (Exception) | ||
| { | ||
| // If runtime fetch fails, return SDKs only — dashboard will show what it can | ||
| return sdkContent; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 19 days ago
To fix the problem, we should replace the generic catch (Exception) with more specific exception handlers that reflect the likely failure modes of invoking and parsing dotnet --list-runtimes. Specifically, failures may come from the process execution (I/O, invalid operation, Task cancellation) or from string/array operations while parsing (argument/out-of-range/format). We can group these into a small, explicit set of exception types and still preserve the current behavior: on these known failures, return sdkContent so the dashboard can show SDKs only.
The best minimal-change fix is:
- Replace
catch (Exception)withcatchclauses for a chosen set of expected exceptions, all of which perform the same fallback tosdkContent. - Optionally add a final
catchforOperationCanceledExceptionif cancellation should also result in a graceful fallback; if cancellation should propagate, we omit that. - Do not alter imports or method signatures; only adjust the catch section of
BuildListSdksWithRuntimesStructuredContentAsync.
Concretely, in DotNetMcp/Tools/Sdk/DotNetCliTools.Sdk.Consolidated.cs, around lines 578–619:
- Replace the single
catch (Exception)block with a grouped catch that handles common runtime and parsing errors, e.g.IOException,InvalidOperationException,FormatException,ArgumentException, andIndexOutOfRangeException, all with identical bodies returningsdkContent. This narrows the catch surface while keeping the observable behavior for these failure types unchanged.
Suggested changeset
1
DotNetMcp/Tools/Sdk/DotNetCliTools.Sdk.Consolidated.cs
| @@ -612,11 +612,31 @@ | ||
|
|
||
| return new { sdks, runtimes }; | ||
| } | ||
| catch (Exception) | ||
| catch (System.IO.IOException) | ||
| { | ||
| // If runtime fetch fails, return SDKs only — dashboard will show what it can | ||
| // If runtime fetch fails due to I/O issues, return SDKs only — dashboard will show what it can | ||
| return sdkContent; | ||
| } | ||
| catch (InvalidOperationException) | ||
| { | ||
| // If runtime fetch fails due to process invocation issues, return SDKs only | ||
| return sdkContent; | ||
| } | ||
| catch (FormatException) | ||
| { | ||
| // If runtime output cannot be parsed as expected, return SDKs only | ||
| return sdkContent; | ||
| } | ||
| catch (ArgumentException) | ||
| { | ||
| // If runtime parsing encounters bad arguments (e.g., Split), return SDKs only | ||
| return sdkContent; | ||
| } | ||
| catch (IndexOutOfRangeException) | ||
| { | ||
| // If runtime parsing encounters unexpected field counts, return SDKs only | ||
| return sdkContent; | ||
| } | ||
| } | ||
|
|
||
| private static object? BuildListRuntimesStructuredContent(string textResult) |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement MCP Apps (SEP-1865) support for the DotnetSdk tool, rendering an interactive HTML dashboard inline in VS Code chat.