docs: refresh README progress section#17
Merged
Conversation
- Status section: drop stale references to the deleted in-repo `ComposeNet.Bindings.*` projects; the facade now references the official `Xamarin.AndroidX.Compose.*` 1.11.1.1 / Material3 1.4.0.x NuGets directly. - Add a `Composables shipped today` table covering all 27 wrapped composables (buttons, text fields, chips, navigation bar/rail, sheets, pickers, dialogs, tooltip). - Source-generator section: document both the generic `ComposeDefaults<T>` and the declarative `ComposeDefaults(...)` forms, with the `!`-prefix and slot-toggle conventions. Removes the inaccurate claim that `ButtonDefault` / `TextDefault` are hand-rolled. - JNI bridges: rename to `ComposeBridges.cs` and call out the `try` / `finally` + `GC.KeepAlive` pattern. - Known issues: drop the obsolete Material3 XA4215 stub-collision item and the `no remember from C#` item; expand the inline-class mangling list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the repository README to reflect the current state of the ComposeNet.Compose facade and its supporting infrastructure (official Xamarin.AndroidX.Compose.* NuGets, generated $default enums, and ComposeBridges.cs JNI bridging), removing stale references to deleted in-repo bindings and outdated status details.
Changes:
- Refreshes the Status/Progress sections to describe the current package sourcing and sample behavior.
- Adds/updates documentation for the shipped composables set and the
$defaultbitmask source generator’s two supported declaration forms. - Updates the JNI bridge and “Known issues / What’s missing” descriptions to align with today’s implementation details and upstream tracking.
Comment on lines
203
to
+204
| 3 UI**, and the counter button is **interactive** (tapping increments | ||
| `MutableState<Int>` and recomposes the `Text`). | ||
| `MutableNumberState<int>` and recomposes the `Text`). |
Comment on lines
+411
to
+414
| Optional slot lambdas the caller toggles per-call (e.g. `AlertDialog`'s | ||
| `dismissButton`/`icon`/`title`/`text`, `NavigationBarItem.label`) stay | ||
| as enum members so the call site can OR them in. Call sites collapse to | ||
| `(int)ButtonDefault.All`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the README in line with where the facade actually is today. The Status section had drifted: it still talked about the in-repo
ComposeNet.Bindings.*projects (deleted when we moved to the officialXamarin.AndroidX.Compose.*1.11.1.1 / Material3 1.4.0.x NuGets), pointed at aComposeApi.csthat's nowComposeBridges.cs, and only mentioned 4 composables when we now wrap 27.Highlights of the rewrite:
ComposeDefaults<T>form and the declarativeComposeDefaults(...)form (with the!-prefix and per-call slot-toggle conventions). Drops the stale claim thatButtonDefault/TextDefaultare hand-rolled — they're generated declaratively now.ComposeBridges.csand calls out thetry/finally+GC.KeepAlivepattern; links [generator] Phase 2: Kotlin @JvmInline value class projection dotnet/java-interop#1440 as the deletion plan.Remember(() => …)(only keyed/nestedrememberis still Tier 2).AlertDialog-Oix01E0,NavigationBar-HsRjFd4,FloatingActionButton-X-z6DiA,ModalBottomSheet-dYc4hso).Docs only — no code or tests touched.