Skip to content

Unwrap nullable in IsValidParameterType #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanalgar merged 2 commits into from
Feb 23, 2025
Merged

Unwrap nullable in IsValidParameterType #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
999f6e0
first shot
jonathanalgar Feb 23, 2025
5d31307
format
jonathanalgar Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/CustomCode-Analyzer/Analyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,6 +1373,16 @@ private static bool IsValidParameterType(ITypeSymbol typeSymbol, Compilation com
return false;
}

// If the type is nullable, unwrap it and check the underlying type
if (
typeSymbol is INamedTypeSymbol named
&& named.OriginalDefinition.SpecialType == SpecialType.System_Nullable_T
&& named.TypeArguments.Length == 1
)
{
typeSymbol = named.TypeArguments[0];
}

// Check for primitive or special types
if (ValidParameterSpecialTypes.Contains(typeSymbol.SpecialType))
{
Expand Down
24 changes: 24 additions & 0 deletions tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,6 +1136,30 @@ await CSharpAnalyzerVerifier<Analyzer>.VerifyAnalyzerAsync(
);
}

[TestMethod]
public async Task UnsupportedParameterTypeRule_InGlobalScope_PublicField_NullableStruct_NoWarning()
{
var test =
@"
[OSStructure]
public struct NestedStructure
{
public int Value;
}

[OSStructure]
public struct MyStructure
{
public NestedStructure? NullableNested; // Nullable struct OK
}
";
await CSharpAnalyzerVerifier<Analyzer>.VerifyAnalyzerAsync(
test,
TestContext,
skipSDKreference: false
);
}

// --------------- ParameterByReferenceRule (OS-ELG-MODL-05016) ------------
[TestMethod]
public async Task ParameterByReferenceRule_InGlobalScope_ReportsWarning()
Expand Down