Skip to content

Fix false positive for unsupported default values on nullable parameters #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanalgar merged 2 commits into from
Feb 22, 2025
Merged

Fix false positive for unsupported default values on nullable parameters #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
159e1d7
first shot
jonathanalgar Feb 22, 2025
b703ec1
merge ifs
jonathanalgar Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/CustomCode-Analyzer/Analyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,11 +1298,22 @@ private static bool IsValidParameterDefaultValue(IParameterSymbol parameter)
return true;
}

// Check if type is supported
// Unwrap nullable types to check the underlying type
ITypeSymbol typeToCheck = parameter.Type;
if (
!ValidParameterSpecialTypes.Contains(parameter.Type.SpecialType)
typeToCheck.OriginalDefinition.SpecialType == SpecialType.System_Nullable_T
&& typeToCheck is INamedTypeSymbol namedType
&& namedType.TypeArguments.Length == 1
)
{
typeToCheck = namedType.TypeArguments[0];
}

// Check if the (unwrapped) type is supported
if (
!ValidParameterSpecialTypes.Contains(typeToCheck.SpecialType)
&& !(
parameter.Type is IArrayTypeSymbol arrayType
typeToCheck is IArrayTypeSymbol arrayType
&& arrayType.ElementType.SpecialType == SpecialType.System_Byte
)
)
Expand All @@ -1322,8 +1333,7 @@ parameter.Type is IArrayTypeSymbol arrayType
return false;
}

// Check if the default value is a literal expression
// This ensures that the default value is a compile-time constant
// Check if the default value is a literal expression (compile-time constant)
return parameterSyntax.Default?.Value is LiteralExpressionSyntax;
}

Expand Down
18 changes: 9 additions & 9 deletions tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1778,25 +1778,25 @@ public async Task UnsupportedDefaultValueRule_ValidLiterals_NoWarning()
public interface ITestInterface
{
void TestMethod(string text = ""hello"",
int number = 42,
int? number = 42,
long bigNumber = 123L,
double precise = 3.14,
decimal money = 10.5m,
bool flag = true,
DateTime date = default,
DateTime? date = default,
string nullString = null);
}

public class Implementation : ITestInterface
{
public void TestMethod(string text = ""hello"",
int number = 42,
long bigNumber = 123L,
double precise = 3.14,
decimal money = 10.5m,
bool flag = true,
DateTime date = default,
string nullString = null) { }
int? number = 42,
long bigNumber = 123L,
double precise = 3.14,
decimal money = 10.5m,
bool flag = true,
DateTime? date = default,
string nullString = null) { }
}";
await CSharpAnalyzerVerifier<Analyzer>.VerifyAnalyzerAsync(
test,
Expand Down