Skip to content

perf: use closures instead of bound functions #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonahsnider wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: use closures instead of bound functions #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/converters/convert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,30 +99,28 @@ function convertToBest<Q extends number | bigint, U extends Unit>(
};
}

type ConverterThis<Q extends number | bigint, U extends Unit> = {
_quantity: Q;
_from: U;
};

function convertToAny<Q extends number | bigint, U extends Unit>(
this: ConverterThis<Q, U>,
quantity: Q,
from: U,
to: MeasuresByUnit<U>,
): LiteralToPrimitive<Q>;
function convertToAny<Q extends number | bigint, U extends Unit, K extends BestKind = 'metric'>(
this: ConverterThis<Q, U>,
quantity: Q,
from: U,
to: 'best',
kind?: K | undefined,
): BestConversion<Q, BestUnitsForUnit<U>>;
function convertToAny<Q extends number | bigint, U extends Unit, K extends BestKind = 'metric'>(
this: ConverterThis<Q, U>,
quantity: Q,
from: U,
to: MeasuresByUnit<U> | 'best',
kind?: K | undefined,
): LiteralToPrimitive<Q> | BestConversion<Q, BestUnitsForUnit<U>> {
if (to === 'best') {
return convertToBest(this._quantity, this._from, kind ?? 'metric');
return convertToBest(quantity, from, kind ?? 'metric');
}

return convertTo(this._from, this._quantity, to);
return convertTo(from, quantity, to);
}

/**
Expand All @@ -143,7 +141,9 @@ export function convert<Q extends number | bigint, U extends Unit>(
throw new RangeError(`${from} is not a valid unit`);
}

return {
to: convertToAny.bind({ _quantity: quantity, _from: from }),
const converter = {
to: (to, kind) => convertToAny(quantity, from, to, kind),
} as Converter<Q, MeasuresByUnit<U>>;

return converter;
}