Fix SpanToJaegerMapper for short trace id handling#135
Conversation
|
@sergeyklay |
|
Hey @croissant-sama ! Thanks a lot for your PR and for taking the time to contribute. I just wanted to let you know that the current changes are causing a syntax error in the tests, so the CI is failing on all PHP versions. The error message is:
It looks like there's a typo in the test file you updated (line 184). Could you double-check that section and fix the syntax error? Once that’s fixed, the CI should pass and I’ll be happy to review your changes again. NB: I also noticed the workflow was failing because it was using a deprecated version of Let me know if you have any questions |
sergeyklay
left a comment
There was a problem hiding this comment.
The changes currently cause a syntax error in the tests
|
@sergeyklay I made the necessary fix. |
|
Hey @sergeyklay! Could you please review my changes? |
|
@croissant-sama thank you! Just released new version https://github.com/jonahgeorge/jaeger-client-php/releases/tag/v1.5.2 |
Some systems remove leading zeros from trace IDs. This PR adds support for short trace IDs without leading zeros.
Implemented according to the approach of the Golang library uber/jaeger-client-go.