Skip to content

Conversation

@joliss
Copy link
Owner

@joliss joliss commented Sep 2, 2025

No description provided.

@joliss joliss changed the title Update dependencies Update dependencies, and require Node >= 20 Sep 2, 2025
@joliss
Copy link
Owner Author

joliss commented Sep 2, 2025

Hey @kategengler, @stefanpenner, long time no speak!

In this PR, I'm updating the minimatch dependency to ^10, which changes the TypeScript interface slightly from IMinimatch to Minimatch in places where minimatch instances are allowed. Since Minimatch 10 requires Node >=20, this PR also requires Node 20 as the minimum version. (All previous Node versions are EoL at this point.)

Do either of you have an opinion or hunch on whether this kind of change warrants a major version bump in walk-sync? In other words, do you think I can publish this as 3.1.0 without making people unhappy, or do you think I should bump to 4.0.0?

@kategengler
Copy link

👋 It's nice to hear from you @joliss!

We do have versions of packages out in the wild with deps on ^3.0.0 of walk-sync that support older nodes than 20, so I think the safer way to go would be a major bump.

@joliss
Copy link
Owner Author

joliss commented Sep 2, 2025

Lovely, that's very helpful @kategengler! I'll push this as 4.0.0.

Hope everything's well!

@joliss joliss merged commit 4d9318c into master Sep 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants