Add input option to Context for passing data to process stdin#799
Open
Amoifr wants to merge 1 commit intojolicode:mainfrom
Open
Add input option to Context for passing data to process stdin#799Amoifr wants to merge 1 commit intojolicode:mainfrom
Amoifr wants to merge 1 commit intojolicode:mainfrom
Conversation
d432275 to
b2671ff
Compare
This allows passing sensitive data (like passwords) to commands via stdin instead of exposing them in command line arguments. Closes jolicode#627
b2671ff to
eb71555
Compare
Author
|
Thanks for the review @pyrech! 🙏 I've pushed a fix:
Let me know if this looks better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #627
Description
This PR adds an
inputoption to theContextclass, allowing users to pass data to a process via stdin. This is useful for commands that require sensitive input (like passwords) without exposing them in command line arguments.Usage
Changes
inputproperty toContextclasswithInput()method toContextclassProcessRunner::run()to use the input when provided