Update CI workflow by removing OS exclusions

.github/workflows/ci.yml

@@ -58,17 +58,17 @@ jobs:
                 exclude:
                     -   php-version: "8.1"
                         symfony: '8.0.*'
-                        operating-system: "ubuntu-latest"
                     -   php-version: "8.2"
                         symfony: '8.0.*'
-                        operating-system: "ubuntu-latest"
                     -   php-version: "8.3"
                         symfony: '8.0.*'
-                        operating-system: "ubuntu-latest"
         steps:
             - name: Checkout
               uses: actions/checkout@v3
 
+            - name: Install gifsicle
+              run: sudo apt-get update && sudo apt-get install -y gifsicle
+
             - name: Setup PHP, with composer and extensions
               uses: shivammathur/setup-php@v2
               with:
@@ -84,7 +84,7 @@ jobs:
               run: echo "::set-output name=dir::$(composer config cache-files-dir)"
 
             - name: Cache composer dependencies
-              uses: actions/cache@v2
+              uses: actions/cache@v4
               with:
                   path: ${{ steps.composer-cache.outputs.dir }}
                   key: ${{ runner.os }}-composer-${{ github.sha }}

Command/GifOptimizerCommand.php

@@ -63,12 +63,16 @@ protected function initialize(InputInterface $input, OutputInterface $output): v
         $optimizationLevel = $input->getOption('optimization_level');
         $width = $input->getOption('resize_width');
 
+        if (!is_numeric($width)) {
+            throw new \Exception('Invalid width.');
+        }
+
         $this->optimizer = OptimizerChainFactory::create()
             ->setOptimizers([
                 new Gifsicle([
                     '-b',
                     $optimizationLevel,
-                    '--resize-width=' . $width,
+                    \sprintf('--resize-width=%s', (string) $width),
                 ]),
             ])
         ;
@@ -79,7 +83,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $imageDir = $input->getArgument('image_dir');
 
         if (!\is_string($imageDir) || !is_dir($imageDir)) {
-            throw new \RuntimeException($imageDir . ' is not a valid directory');
+            throw new \RuntimeException('image_dir is not a valid directory');
         }
 
         $pattern = $imageDir . '/*/*.gif';

EventListener/ReplaceImageListener.php

@@ -37,7 +37,7 @@ public function onKernelResponse(ResponseEvent $event): void
         }
 
         $exception = $event->getRequest()->attributes->get('exception');
-        if (!($exception instanceof \Throwable)) {
+        if (!$exception instanceof \Throwable) {
             return;
         }
 

bin/optimizer.php

@@ -22,7 +22,7 @@
 }
 
 $application = new Application('gifexception');
-$application->add(new GifOptimizerCommand());
+$application->addCommand(new GifOptimizerCommand());
 $application
     ->setDefaultCommand('gifexception:optimize', true)
     ->run()

tests/app/config/routing.php

@@ -11,7 +11,7 @@
 
 use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;
 
-return function (RoutingConfigurator $routes): void {
+return static function (RoutingConfigurator $routes): void {
     $routes->add('test_routing_error', '/error-{status}')
         ->requirements(['status' => '\d+'])
         ->defaults(['_controller' => 'Joli\GifExceptionBundle\Tests\app\src\TestController::errorAction'])