-
-
Notifications
You must be signed in to change notification settings - Fork 197
Hide Window on start config option #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fr33mang
wants to merge
10
commits into
johnste:main
Choose a base branch
from
fr33mang:claude/serene-ritchie-ekADv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
28c8c66
fix(window): defer window auto-open to avoid flash on cold URL launch
claude 1748e76
feat(config): add suppressWindow option to never auto-open the window
claude 82488b8
fix(ui): include suppressWindow in config options sent to the UI
claude 17df615
fix(window): keep Finicky in background when routing URLs from other …
claude 685eed9
fix(build): remove stale .app bundles before building
claude ee56201
refactor(window): rename suppressWindow to hideWindowOnStart and drop…
claude e385f41
revert: restore original bundle version in Info.plist
claude c6ff5e7
fix(startup): build VM from rules files that contain only options
claude a6f8ce1
test(rules): cover options-only ToJSConfigScript output
claude c676873
revert(window): drop NSApp hide on URL routing
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,6 +62,13 @@ build_arch() { | |
| -o ../build/${APP_NAME}/Contents/MacOS/Finicky | ||
| } | ||
|
|
||
| # Remove stale .app bundles from previous builds. Without this, a second local | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure that is needed that but locally I've stuck on rebuild because of some files left from previous build run I can remove or create a separate PR for that code change |
||
| # build fails because `mv Finicky-arm64.app Finicky.app` nests the new bundle | ||
| # inside the existing Finicky.app directory instead of replacing it. | ||
| rm -rf apps/finicky/build/Finicky.app \ | ||
| apps/finicky/build/Finicky-arm64.app \ | ||
| apps/finicky/build/Finicky-amd64.app | ||
|
|
||
| if [ "${BUILD_UNIVERSAL:-0}" = "1" ]; then | ||
| build_arch arm64 | ||
| build_arch amd64 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.