This repository was archived by the owner on Feb 26, 2026. It is now read-only.
Replace hardcoded 'zQ3sh' with SECP256K1_PUBLIC_MULTIBASE_PREFIX constant#49
Merged
johnbillion merged 2 commits intoclaude/implement-issue-41-UGAc0from Jan 19, 2026
Merged
Conversation
…tant Co-authored-by: johnbillion <208434+johnbillion@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add implementation to address rotation key validity check feedback
Replace hardcoded 'zQ3sh' with SECP256K1_PUBLIC_MULTIBASE_PREFIX constant
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #47 to use the
SECP256K1_PUBLIC_MULTIBASE_PREFIXconstant instead of a hardcoded string for consistency.Changes:
getRotationPublicKeyMultibase()to use the constant in both the validation check and error messageThis aligns with line 313 which already uses the constant.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.