Set event variable on start and ad support for a kill flag#98
Open
Cypher1 wants to merge 3 commits intojoh:masterfrom
Open
Set event variable on start and ad support for a kill flag#98Cypher1 wants to merge 3 commits intojoh:masterfrom
Cypher1 wants to merge 3 commits intojoh:masterfrom
Conversation
Cypher1
changed the title
Owner
|
Hi, thank you for the PR and sorry for the late reply. Your PR includes a commit that was previously rejected in PR #85 due to some unexpected issues. These needs to be addressed before merging. If you wish to work on this, please re-open #85. The env variable fix looks fine, can you please update this PR to only include that one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The env variable event was previously unset in the case of the first run. This isn't impossible to handle in scripts using $event but it is more convenient to provide a consistent value.