Fix autogen.sh failing to find gettext #662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...which was preventing proper ./configure generation and making build from git sources impossible. Now it should look for gettext inside of ./m4/* before trying to get it from system directories. Running autogen.sh still produces some warnings about missing gettext variables and errors about missing 'Makefile.am' files but './configure && make' should succeed anyway without any issues. This issue was mentioned in: joewing#659 (comment) joewing#658 (comment) Tested on latest ArchLinux with: gettext (GNU gettext-runtime) 0.26 automake (GNU automake) 1.18.1 autoconf (GNU Autoconf) 2.72 also tested on Ubuntu 25.04 with: gettext (GNU gettext-runtime) 0.23.1 automake (GNU automake) 1.17 autoconf (GNU Autoconf) 2.72
Author
|
Also few notes after spending some time on figuring out how the build process of JWM works:
That said, I'm not very familiar with Autotools so maybe I'm just spreading nonsense right now... (sorry) |
Author
|
Also it seem that people at AUR had this exact issue according to: https://aur.archlinux.org/packages/jwm-git#comment-1038518 |
Author
|
Rethinking this problem after some time... I think this can be also fixed by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which was preventing proper ./configure generation and making build from git sources impossible. Now it should look for gettext inside of ./m4/* before trying to get it from system directories.
Running autogen.sh still produces some warnings about missing gettext variables and errors about missing 'Makefile.am' files but './configure && make' should succeed anyway without any issues.
This issue was mentioned in:
#659 (comment) #658 (comment)
Tested on latest ArchLinux with:
gettext (GNU gettext-runtime) 0.26
automake (GNU automake) 1.18.1
autoconf (GNU Autoconf) 2.72
also tested on Ubuntu 25.04 with:
gettext (GNU gettext-runtime) 0.23.1
automake (GNU automake) 1.17
autoconf (GNU Autoconf) 2.72