CMake conversion

[ghost]

So this is the basic initial start to a cmake conversion. the configure script is currently located in the cmake folder and needs a ton of work. That said, you can:
mkdir bin
cd bin
cmake ..
make
And it works (at least for me) I have a bunch of the autoconf stuff built into cmake, but this is incomplete but a good place to start 😄

[ghost]

nevermind I accidentally reverted something I'll make a new pr

[ghost]

Ok, this should be fine now. It doesn't interfere with the current build system, and will not need to until it works fully, we can move the configure script into the main directory once it is in a good working state.

[rdnvndr]

I have a error:

...
...
-- Looking for XShapeCombineRectangles in Xext
-- Looking for XShapeCombineRectangles in Xext - found
-- Performing Test ICONV_CONST
-- Performing Test ICONV_CONST - Failed
-- Performing Test _XOPEN_SOURCE_EXTENDED
-- Performing Test _XOPEN_SOURCE_EXTENDED - Failed
-- Found Gettext: /usr/sbin/msgmerge (found version "0.19.8.1") 
msgfmt: /usr/sbin/msgfmt
msgmerge: /usr/sbin/msgmerge
creating jwm.1
CMake Error: File /home/andrey/temp/jwm/cmake/config.h.in does not exist.
CMake Error at CMakeLists.txt:312 (configure_file):
  configure_file Problem configuring file


Compiler:  /usr/sbin/cc
Compiler Flags: -O3 -DNDEBUG
-- Configuring incomplete, errors occurred!
See also "/home/andrey/temp/jwm/bin/CMakeFiles/CMakeOutput.log".
See also "/home/andrey/temp/jwm/bin/CMakeFiles/CMakeError.log".

[joewing]

Very nice! I haven't dug in too much yet, but I've run into the same problem as @rdnvndr.

[ghost]

Ah, yes gitignore was hiding it.

To be clear this is still very experimental and will need a good amount of work to finish porting all the features, specifically the configure switches which almost all do nothing as of yet. but the script cmake/configure has some basic ideas sketched out for how to accomplish it, and I can work more on it later.

There are still some platform checks that need to be actually implemented as well, but most things are in place and work. At least I can compile it and it works well enough to warrant sending this to you as experimental for others to hack and get working perfectly 😄

[rdnvndr]

It works, but without localization. @Israel- need your help ;-)

[ghost]

Ok... this works much better with @rdnvndr fixing the translations code. There is still work to be done to make everything work the same as before.

[ghost]

@joewing I am working on the configure script and was wondering what of these options do we not need?
It seems like things such as
--runstatedir=
are not pertinent to JWM, but I want to add all the features we need.
Some of them are really obviously needed, of course (--enable/disable-* )
thanks

[rdnvndr]

The problem repeated:

...
CMake Error: File /home/andrey/projects/jwm/cmake/config.h.in does not exist.
CMake Error at CMakeLists.txt:379 (configure_file):
  configure_file Problem configuring file
...

[rdnvndr]

Typo:
https://github.com/Israel-D/jwm/blob/049a5cb408696691f139a4c5b20bea58f397819f/cmake/configure#L208

Must be: fi

[ghost]

@rdnvndr you are absolutely correct. The configure script is my compatibility layer for the current autoconf stuff. You can try it now, it should work better. I am still not sure if some of those options are needed, like:
--runstatedir=DIR
so some do not work.

There are also a few minor issues with detecting some things still in the cmakelists, but it is getting a lot closer, thanks for your help @rdnvndr !

[ghost]

@joewing Can you provide more information on what options the configure script actually needs?
The cmake version is getting very close to being ready for wider usage and testing, I'd like to get the configure script up to parity with the autoconf version.

[rdnvndr]

@Israel-d Thanks for the good work is done!
@joewing please apply pull request as the alternative variant of building.

[ghost]

@rdnvndr It might be better to do a clean repo, and simply add these changes into it, to make it a cleaner PR.
I still want some feedback from @joewing about the configure options as well

[01micko]

I know this is an old PR, but would it be more productive to add meson? IMHO it is simpler than cmake and autotools.

In gtkdialog we have autotools and meson coexisting.