Update gorilla to 1.5.2, update go to 1.22.3, and add github action to build and test on each PR#446
Open
barakplasma wants to merge 6 commits intojoewalnes:masterfrom
Open
Conversation
barakplasma
force-pushed
the
update-gorilla-to-1-5-2
branch
from
177ca55 to
f5ba70d
Compare
barakplasma
changed the title
barakplasma
changed the title
barakplasma
force-pushed
the
update-gorilla-to-1-5-2
branch
from
4181402 to
4e54954
Compare
… --port (joewalnes#431) kudos to Michail Kovtun for reporting it
Convert flag.Usage to flag.CommandLine.Usage for avoid showing the default help message printout
update go version to 1.22.3
fix: nektos/act isn't the same as the runner fix: another try fix: fix: fix: fix: fix: fix: fix: fix:
barakplasma
force-pushed
the
update-gorilla-to-1-5-2
branch
from
fc4a874 to
92ff584
Compare
barakplasma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
building off of #430
also adds a github action to make sure the makefile builds binaries successfully before allowing a PR to be merged. also tests the binaries by connecting to the example bash script for dump env and making sure it sends an eof at the end
added an example in https://github.com/barakplasma/websocketd/actions/runs/9455903924
easier than using the makefile is to use go-releaser like I'm doing in my fork (generated by the github action workflow at https://github.com/barakplasma/websocketd/blob/master/.github/workflows/release.yml )
I built binaries for all platforms on the latest golang in
https://github.com/barakplasma/websocketd/releases/tag/0.4.2