Skip to content

feat: remake example to include package.json testing#1

Open
mnaoumov wants to merge 1 commit into
joethei:masterfrom
mnaoumov:master
Open

feat: remake example to include package.json testing#1
mnaoumov wants to merge 1 commit into
joethei:masterfrom
mnaoumov:master

Conversation

@mnaoumov

@mnaoumov mnaoumov commented Jan 2, 2026

Copy link
Copy Markdown

It assumes obsidianmd/eslint-plugin#80 merged.
You can merge it locally and then npm install --dev path/to/eslint-plugin

@mnaoumov

mnaoumov commented Jan 2, 2026

Copy link
Copy Markdown
Author
> npm run lint

> obsidian-sample-plugin@1.0.0 lint
> eslint .


F:\dev\work\obsidian\joethei-obsidian-sample-plugin\package.json
  27:3  error  "moment" should be replaced with an alternative package. Read more here: https://github.com/es-tooling/module-replacements/blob/main/docs/modules/momentjs.md  depend/ban-dependencies

F:\dev\work\obsidian\joethei-obsidian-sample-plugin\src\main.ts
   6:22  error  Rename the sample classes                                                                                                               
                  obsidianmd/sample-names
  69:3   error  Remove the sample `registerInterval` call from the plugin template                                                                      
                  obsidianmd/no-sample-code
  69:50  error  [no-console] Avoid unnecessary logging to console. See https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Avoid+unnecessary+logging+to+console  obsidianmd/rule-custom-message
  85:7   error  Rename the sample classes                                                                                                               
                  obsidianmd/sample-names

F:\dev\work\obsidian\joethei-obsidian-sample-plugin\src\settings.ts
   4:18  error  Rename the sample classes  obsidianmd/sample-names
  12:14  error  Rename the sample classes  obsidianmd/sample-names

✖ 7 problems (7 errors, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant