Fix derived type being tracked as base type #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Joel,
#1 I took the liberty of making changes to address the issue #72 when collection item proxies created were of incorrect type. Please find PR below that addresses the issue.
#2 This is something I am not very fluent with. My gut tells me that the declaration below
public interface IChangeTrackable<T> : IChangeTrackableshould be changed to
public interface IChangeTrackable<out T> : IChangeTrackable(i.e. to to being contravariant).This, however, causes conflicts with GetOriginalValue declaration.
TResult GetOriginalValue<TResult>(Expression<Func<T, TResult>> selector);I am, unfortunately, not quite at arm lengths with contra- and co- variant interfaces and cannot clearly propose the best plant of action. Besides this strategical idea, my changes are quite limited and all the existing tests pass.