✨ Added onKey() and onValue() callbacks#4
Open
iMrDJAi wants to merge 12 commits into
Open
Conversation
…)` when dealing with non-CBORValues
Author
|
@joeltg Hi. Sorry for the ping. Could you please take a look and tell me what you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joeltg This PR is mainly for adding
onKey()andonValue()callbacks for key mapping and value validation/transformation. Please refer to README for more details.In the process, I have fixed many bugs including backpressure in streams and tested against both Bun and Node (Although, I haven't really written tests, feel free to get @claude to generate them if you want).
I also had to revert #2, as I found a simpler solution that eliminates unnecessary allocations.
While I made sure to keep the API backwards compatible, I guess the new features and changes deserve having a new major release for this project.
I know it took me a while, but I ran across multiple bugs in both Bun and Node regarding
fetch()streams that made me rethink the backpressure implementation from the ground up. And at the end, I delivered 🎉.