This repository was archived by the owner on Aug 1, 2022. It is now read-only.
Fix JS getProject() being called on every pages#24
Open
goodtouch wants to merge 1 commit intojoelmoss:masterfrom
Open
Fix JS getProject() being called on every pages#24goodtouch wants to merge 1 commit intojoelmoss:masterfrom
goodtouch wants to merge 1 commit intojoelmoss:masterfrom
Conversation
It seems that getProject() was not intended to be called on every page but only on projects/:id (?) (using the `location` property, makes it query invalid pages like /project/1/jobs/new/deploy.json when called on all pages)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that getProject() was not intended to be called on every page but only on projects/:id (?)
(using the
locationproperty, makes it query invalid pages like /project/1/jobs/new/deploy.json when called on all pages)