Skip to content

FLUID-6324: use @waharnum's fork of docpad-plugin-handlebars#1

Merged
jobara merged 1 commit intojobara:FLUID-6324from
waharnum:FLUID-6324
Jan 8, 2019
Merged

FLUID-6324: use @waharnum's fork of docpad-plugin-handlebars#1
jobara merged 1 commit intojobara:FLUID-6324from
waharnum:FLUID-6324

Conversation

@waharnum
Copy link
Copy Markdown

@waharnum waharnum commented Dec 10, 2018

I've fixed the Handlebars plugin for the 6.82.x line of Docpad.

I will open a pull request to the plug-in to discuss my fix and potentially get it merged upstream, but for now this allows the docs site to be generated with the 6.82.x line of Docpad.

My PR at docpad/docpad-plugin-handlebars#13 - we can update our use of the plugin should that get merged.

@waharnum waharnum changed the base branch from master to FLUID-6324 December 10, 2018 18:38
@jobara jobara merged commit a5e52a1 into jobara:FLUID-6324 Jan 8, 2019
@jobara
Copy link
Copy Markdown
Owner

jobara commented Jan 8, 2019

@waharnum thanks for providing this stop gap while we wait for them to merge your PR.

@waharnum
Copy link
Copy Markdown
Author

waharnum commented Jan 8, 2019

As noted in our convo, this doesn't work in current state because of the compile step that happens (typically) as part of the plug-in publishing to NPM.

Working around this is probably a matter of publishing a branch with the compile step completed (publishing our own version to NPM seems like overkill).

@jobara
Copy link
Copy Markdown
Owner

jobara commented Jan 8, 2019

If we end up publishing to NPM we should publish it as an org scoped package ( https://docs.npmjs.com/creating-and-publishing-an-org-scoped-package )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants