Fixing letterOf and positionOf to use Arrays as lengthOf does#3188
Open
jguille2 wants to merge 1 commit intojmoenig:masterfrom
Open
Fixing letterOf and positionOf to use Arrays as lengthOf does#3188jguille2 wants to merge 1 commit intojmoenig:masterfrom
jguille2 wants to merge 1 commit intojmoenig:masterfrom
Conversation
Collaborator
|
Thanks! This LGTM. We should have done this a while ago. :) |
aelnosu
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
It is related to #3183
If finally we keep current "Arrays operation" with "length of string" block, this PR fixes "letter of" and "position of" to be coherent with it.
There are more blocks affected, from "strings" and "word-sentence" libraries... but all based on "letterOf" and "positionOf" blocks
Because here (github PR) custom block changes are not easily shown, I paste that block here: