fix(remote): download without tqdm; benchmark report to job summary (0.1.2)#3
Merged
Merged
Conversation
…ents (0.1.2) download() crashed on a clean install: pooch's progress bar requires tqdm, which is not a resolvekit dependency. Downloads now show a progress bar when tqdm is installed and run silently when it isn't. benchmark.yml: the full benchmark report goes to the run's job summary and artifact instead of a PR comment — clean CI lacks the remote tiers, so the absolute numbers are misleading and add noise rather than review signal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download fix (found verifying 0.1.1 on a truly clean venv):
download()crashed with "Missing package 'tqdm' required for progress bars" — pooch's progress bar needs tqdm, which isn't among resolvekit's five runtime deps. Every earlier verification ran in environments that happened to have tqdm. Nowprogressbar=is passed based on tqdm availability: progress bar when present, silent download when not. Verified on a clean venv without tqdm: real download + resolve succeed.Benchmark PR comments removed (maintainer feedback): the workflow dumped the entire report (hardware, dataset hashes, every tool × metric × four breakdown tables) into the PR thread, with misleadingly-low resolvekit numbers since clean CI lacks remote tiers. The report now lands in the workflow job summary (one click from Checks) plus the existing 30-day artifact;
pull-requests: writepermission dropped.Plus 0.1.2 bump, CHANGELOG, doc version strings, 2 new tests. Full suite: 3482 passed, 44 skipped.