fix(loading): partial remote caches + OECD DAC notice correction (0.1.1)#2
Merged
Conversation
…tice (0.1.1) Partial remote caches are first-class: declared dependencies on remote packs absent from the local cache are skipped during dependency validation and explicit-mode queuing, instead of raising MissingModuleDependencyError from Resolver.auto() or transitively queuing ~796 MB of siblings. Bundled, cached, and unknown dependencies remain hard errors. NOTICE.md: OECD distributes content under CC BY 4.0 (commercial use permitted) since July 2024 — the previous wording claimed a non-commercial restriction. Documents the DAC contribution to the org entity store and fixes the upstream URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes shipped together as 0.1.1:
Partial-cache loading fix (live-reproduced on the published 0.1.0 wheel):
download('geo.admin1')→Resolver.auto()raisedMissingModuleDependencyErrordemanding geo.admin2/admin3/cities.Resolver.lite(module_ids=['geo.countries','geo.admin1'])transitively queued every declared sibling (~796 MB) and raisedDataPackNotAvailableError.Root cause: the shipped metadata over-declares sibling tiers as hard deps (build-time artifact of the shared geo store — admin1's sqlite has zero references to those modules), and the validator wasn't aware of the loader's documented auto-mode intent to skip uncached remote packs. This PR makes remote-and-uncached declared deps soft at load time (validation + explicit-mode queuing); bundled, cached, and unknown deps remain hard errors. The metadata over-declaration itself is documented separately for a follow-up data fix.
Verified live on a fresh cache: both failing paths now resolve 'Bavaria' → nuts/DE2 with only admin1 downloaded, no sibling fetch attempted.
NOTICE.md OECD DAC correction: OECD's terms have been CC BY 4.0 (attribution, commercial use permitted) since 1 July 2024; the old wording claimed 'non-commercial and research use'. Also documents the DAC codelists' contribution to the org entity store and points Upstream at the actual codelists portal.
Plus: 0.1.1 version bump, CHANGELOG entry, doc version strings, 7 new unit tests + 1 remote-data-gated integration repro. Full suite: 3480 passed, 44 skipped.