test(suggest): gate remote-tier assertions behind requires_remote_data#1
Merged
Merged
Conversation
The two 'york' tests assert geoId/36 (New York admin1) in suggest results, which requires the remote admin1 tier — absent in clean CI, present only on machines with a warm cache. Mark them requires_remote_data per the suite convention so clean CI skips them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial-commit CI run failed on all three OSes:
test_suggest_york_returns_new_york_admin1andtest_suggest_default_to_with_on_missing_raise_does_not_raiseassertgeoId/36(New York admin1) insuggest('york'), but admin1 is a remote tier that clean CI never downloads. They pass only on machines with a warm cache (same failure existed on the dev repo's final run — pre-existing, not migration-related).Fix: mark both
@pytest.mark.requires_remote_data, the suite's existing convention for remote-tier tests.Verified locally:
pytest tests/test_suggest.py→ 29 passed 2 skipped; with--run-remote-data→ 31 passed.