Conversation
…ierarchy All public and internal exceptions now inherit from SocketryError(Exception) instead of RuntimeError or bare Exception, giving callers a single typed catch-all and preventing RuntimeError from leaking as an ambiguous escape. MqttError(SocketryError, ConnectionError) retains the ConnectionError base so existing broad except clauses are unaffected. Fixes: #33 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jlopez
added a commit
that referenced
this pull request
Mar 2, 2026
### Bug Fixes * **ci:** update uv.lock on release-please PRs ([#38](#38)) ([f7cf4ad](f7cf4ad)) * **client:** introduce SocketryError base class; clean up exception hierarchy ([#36](#36)) ([20516ec](20516ec)), closes [#33](#33) * **client:** raise AuthenticationError instead of RuntimeError on login failure ([#34](#34)) ([772e552](772e552)), closes [#32](#32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SocketryError(Exception)as the common base for all socketry exceptionsAuthenticationError,MqttError,TokenExpiredError, and_SessionInvalidatedErrorall now inherit fromSocketryErrorinstead ofRuntimeErroror bareExceptionMqttError(SocketryError, ConnectionError)retainsConnectionErroras a second base so existingexcept ConnectionErrorclauses are unaffectedSocketryErroris exported from the top-levelsocketrypackageTestSocketryErrorExported)Test plan
uv run pytest)MqttErrorstill satisfiesisinstance(e, ConnectionError)(tested)RuntimeError(tested)Fixes: #33
🤖 Generated with Claude Code