Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions InvoiceReminder.API.UnitTests/InvoiceReminder.API.UnitTests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,6 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Shouldly" Version="4.3.0" />

<!--<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageReference Include="Microsoft.Testing.Extensions.CodeCoverage" Version="17.14.2" />
<PackageReference Include="Microsoft.Testing.Extensions.TrxReport" Version="1.6.3" />
<PackageReference Include="MSTest.TestAdapter" Version="3.8.3" />
<PackageReference Include="MSTest.TestFramework" Version="3.8.3" />
<PackageReference Include="MSTest.Analyzers" Version="3.8.3">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>-->
</ItemGroup>

<ItemGroup>
Expand All @@ -40,30 +30,30 @@
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.14.1" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.CodeCoverage" Version="17.14.2" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.6.3" />
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.7.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.Analyzers" Version="3.8.3">
<PackageReference Update="MSTest.Analyzers" Version="3.9.3">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestAdapter" Version="3.8.3" />
<PackageReference Update="MSTest.TestAdapter" Version="3.9.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestFramework" Version="3.8.3" />
<PackageReference Update="MSTest.TestFramework" Version="3.9.3" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -27,30 +27,30 @@
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.14.1" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.CodeCoverage" Version="17.14.2" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.6.3" />
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.7.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.Analyzers" Version="3.8.3">
<PackageReference Update="MSTest.Analyzers" Version="3.9.3">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestAdapter" Version="3.8.3" />
<PackageReference Update="MSTest.TestAdapter" Version="3.9.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestFramework" Version="3.8.3" />
<PackageReference Update="MSTest.TestFramework" Version="3.9.3" />
</ItemGroup>
Comment on lines +42 to 54
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Alinhar versões do ecossistema MSTest para evitar incompatibilidade

Os pacotes MSTest.Analyzers, MSTest.TestAdapter e MSTest.TestFramework foram atualizados para 3.9.3, porém o SDK raiz continua em 3.6.4.
Prática recomendada: manter todos na mesma versão principal/menor para garantir que regras de analisador, adapter e framework conversem corretamente com o SDK.

Proposta:

-<Project Sdk="MSTest.Sdk/3.6.4">
+<Project Sdk="MSTest.Sdk/3.9.3">

Isso eliminará possíveis avisos de compatibilidade e garante suporte completo a novas features introduzidas na série 3.9.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In
InvoiceReminder.Application.UnitTests/InvoiceReminder.Application.UnitTests.csproj
around lines 42 to 54, the MSTest package versions are inconsistent, with some
updated to 3.9.3 while the root SDK remains at 3.6.4. To fix this, update the
root MSTest SDK version to 3.9.3 to align with the other MSTest packages,
ensuring all MSTest components use the same major and minor version to avoid
compatibility issues and enable full support for new features.


</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,37 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\InvoiceReminder.API\InvoiceReminder.API.csproj" />
<ProjectReference Include="..\InvoiceReminder.Application\InvoiceReminder.Application.csproj" />
<ProjectReference Include="..\InvoiceReminder.Data\InvoiceReminder.Data.csproj" />
<ProjectReference Include="..\InvoiceReminder.Domain\InvoiceReminder.Domain.csproj" />
</ItemGroup>

<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
<ItemGroup>
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.13.0" />
</ItemGroup>
Comment on lines +27 to +29
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Versão do Microsoft.NET.Test.Sdk divergente do restante da solução
Os outros projetos de teste foram atualizados para 17.14.1, enquanto aqui houve downgrade para 17.13.0. Misturar runners de versão diferente costuma gerar falhas intermitentes ou relatórios de cobertura incompatíveis.

Sugestão de ajuste:

-    <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.13.0" />
+    <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.14.1" />
🤖 Prompt for AI Agents
In InvoiceReminder.ArchitectureTests/InvoiceReminder.ArchitectureTests.csproj at
lines 27 to 29, the Microsoft.NET.Test.Sdk package version is set to 17.13.0,
which is inconsistent with other test projects using version 17.14.1. Update the
Version attribute of the PackageReference for Microsoft.NET.Test.Sdk to 17.14.1
to align with the rest of the solution and avoid potential test runner conflicts
or coverage report issues.


<PackageReference Include="Microsoft.Testing.Extensions.CodeCoverage" Version="17.14.2" />
<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.CodeCoverage" Version="17.14.2" />
</ItemGroup>

<PackageReference Include="Microsoft.Testing.Extensions.TrxReport" Version="1.7.3" />
<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.7.3" />
</ItemGroup>

<PackageReference Include="MSTest.Analyzers" Version="3.9.3" />
<ItemGroup>
<PackageReference Update="MSTest.Analyzers" Version="3.9.3">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<PackageReference Include="MSTest.TestAdapter" Version="3.9.3" />
<ItemGroup>
<PackageReference Update="MSTest.TestAdapter" Version="3.9.3" />
</ItemGroup>

<PackageReference Include="MSTest.TestFramework" Version="3.9.3" />
<ProjectReference Include="..\InvoiceReminder.API\InvoiceReminder.API.csproj" />
<ProjectReference Include="..\InvoiceReminder.Application\InvoiceReminder.Application.csproj" />
<ProjectReference Include="..\InvoiceReminder.Data\InvoiceReminder.Data.csproj" />
<ProjectReference Include="..\InvoiceReminder.Domain\InvoiceReminder.Domain.csproj" />
<ItemGroup>
<PackageReference Update="MSTest.TestFramework" Version="3.9.3" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -25,30 +25,30 @@
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.14.1" />
</ItemGroup>
Comment on lines +28 to 29
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verifique o “mix” de SDKs antes do merge

Você atualizou Microsoft.NET.Test.Sdk para 17.14.1, porém o projeto continua ancorado em <Project Sdk="MSTest.Sdk/3.6.4">.
Isso pode gerar conflitos de assembly-binding e warnings de versão, pois:

  1. MSTest.Sdk 3.6.4 traz transitive refs do trio MSTest.* em versão 3.6.*.
  2. Agora você injeta explicitamente MSTest.* 3.9.3 + Microsoft.NET.Test.Sdk 17.14.1.

Recomendo alinhar tudo em torno da mesma major/minor (ex.: subir o cabeçalho para MSTest.Sdk/3.9.3 ou voltar para Microsoft.NET.Sdk + refs explícitas) antes de prosseguir.

Exemplo de ajuste sugerido fora deste trecho:

-<Project Sdk="MSTest.Sdk/3.6.4">
+<Project Sdk="MSTest.Sdk/3.9.3">

Para confirmar a versão do SDK e as referências de pacote neste projeto de testes, execute:


🏁 Script executed:

#!/bin/bash
grep -n "<Project Sdk" InvoiceReminder.DomainEntities.UnitTests/InvoiceReminder.DomainEntities.UnitTests.csproj
grep -n "PackageReference.*Microsoft.NET.Test.Sdk" InvoiceReminder.DomainEntities.UnitTests/InvoiceReminder.DomainEntities.UnitTests.csproj

Length of output: 369


Alinhar versão do Project Sdk com o pacote de testes

O projeto de testes está declarando

<Project Sdk="MSTest.Sdk/3.6.4">

enquanto o Microsoft.NET.Test.Sdk foi elevado para a versão 17.14.1. Esse “mix” de versões pode causar conflitos de binding e avisos de versão em tempo de build.

Pontos a ajustar:

  • InvoiceReminder.DomainEntities.UnitTests/InvoiceReminder.DomainEntities.UnitTests.csproj
    • Linha 1: <Project Sdk="MSTest.Sdk/3.6.4">
    • Linha 28: <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.14.1" />

Sugestões de correção (escolha uma abordagem):

  • Atualizar o header do projeto para usar o MSTest.Sdk/3.9.3, mantendo tudo em major/minor 3.9.x.
  • Ou migrar para <Project Sdk="Microsoft.NET.Sdk"> e referenciar explicitamente Microsoft.NET.Test.Sdk, MSTest.TestAdapter e MSTest.TestFramework com versões alinhadas.

Exemplo de diff para a primeira opção:

-<Project Sdk="MSTest.Sdk/3.6.4">
+<Project Sdk="MSTest.Sdk/3.9.3">
🤖 Prompt for AI Agents
In
InvoiceReminder.DomainEntities.UnitTests/InvoiceReminder.DomainEntities.UnitTests.csproj
at lines 1 and 28-29, the Project Sdk version MSTest.Sdk/3.6.4 conflicts with
the updated Microsoft.NET.Test.Sdk package version 17.14.1, causing potential
binding issues. To fix this, update the Project Sdk declaration on line 1 to
MSTest.Sdk/3.9.3 to align with the test package version, ensuring consistent
major/minor versions and avoiding conflicts.


<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.CodeCoverage" Version="17.14.2" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.6.3" />
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.7.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.Analyzers" Version="3.8.3">
<PackageReference Update="MSTest.Analyzers" Version="3.9.3">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestAdapter" Version="3.8.3" />
<PackageReference Update="MSTest.TestAdapter" Version="3.9.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestFramework" Version="3.8.3" />
<PackageReference Update="MSTest.TestFramework" Version="3.9.3" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="MSTest.Sdk/3.6.4">
<Project Sdk="MSTest.Sdk/3.6.4">

<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
Expand Down Expand Up @@ -29,30 +29,30 @@
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.14.1" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.CodeCoverage" Version="17.14.2" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.6.3" />
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.7.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.Analyzers" Version="3.8.3">
<PackageReference Update="MSTest.Analyzers" Version="3.9.3">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestAdapter" Version="3.8.3" />
<PackageReference Update="MSTest.TestAdapter" Version="3.9.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestFramework" Version="3.8.3" />
<PackageReference Update="MSTest.TestFramework" Version="3.9.3" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -31,30 +31,30 @@
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.14.1" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.CodeCoverage" Version="17.14.2" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.6.3" />
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.7.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.Analyzers" Version="3.8.3">
<PackageReference Update="MSTest.Analyzers" Version="3.9.3">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestAdapter" Version="3.8.3" />
<PackageReference Update="MSTest.TestAdapter" Version="3.9.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestFramework" Version="3.8.3" />
<PackageReference Update="MSTest.TestFramework" Version="3.9.3" />
</ItemGroup>
Comment on lines +46 to 58
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Alinhe a versão do SDK declarado no topo com os pacotes MSTest 3.9.3.

O projeto usa <Project Sdk="MSTest.Sdk/3.6.4">, mas os pacotes MSTest.* foram atualizados para 3.9.3. Manter versões divergentes entre o SDK e o Adapter/TestFramework pode gerar:

• avisos MSB3277 de conflito de assembly;
• falhas de descoberta de testes em tempo de execução;
• perda de diagnósticos recentes do Analyzers.

Sugestão:

-<Project Sdk="MSTest.Sdk/3.6.4">
+<Project Sdk="MSTest.Sdk/3.9.3">

Caso o objetivo seja usar apenas o SDK padrão (Microsoft.NET.Sdk) com pacotes externos, considere substituir pelo Microsoft.NET.Sdk e remover a dependência explícita de MSTest.Sdk.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In
InvoiceReminder.Infrastructure.UnitTests/InvoiceReminder.Infrastructure.UnitTests.csproj
around lines 46 to 58, the project SDK version MSTest.Sdk/3.6.4 declared at the
top is outdated compared to the MSTest package versions 3.9.3 used in the
dependencies. To fix this, either update the SDK version to match 3.9.3 or
replace the SDK declaration with Microsoft.NET.Sdk and remove the explicit
MSTest.Sdk dependency to avoid assembly conflicts, test discovery failures, and
analyzer issues.


</Project>
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="MSTest.Sdk/3.6.4">
<Project Sdk="MSTest.Sdk/3.6.4">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Atualize o SDK do projeto para manter compatibilidade com os pacotes MSTest 3.9.3

Os pacotes MSTest.TestFramework/Adapter/Analyzers foram elevados para 3.9.3, mas o SDK do projeto continua em 3.6.4. Isso pode gerar warnings ou comportamentos inesperados (features de assert, message diagnostics, etc.) caso exista quebra de contrato entre as versões.

-<Project Sdk="MSTest.Sdk/3.6.4">
+<Project Sdk="MSTest.Sdk/3.9.3">

Para confirmar o Sdk e as versões dos pacotes MSTest configurados neste projeto, vou inspecionar o arquivo csproj:


🏁 Script executed:

#!/bin/bash
# Exibe as primeiras linhas do csproj para verificar o atributo <Project Sdk=…>
sed -n '1,20p' InvoiceReminder.JobScheduler.UnitTests/InvoiceReminder.JobScheduler.UnitTests.csproj

echo "Referências aos pacotes MSTest e suas versões:"
grep -E "<PackageReference.*MSTest.TestFramework" -n InvoiceReminder.JobScheduler.UnitTests/InvoiceReminder.JobScheduler.UnitTests.csproj
grep -E "<PackageReference.*MSTest.TestAdapter"   -n InvoiceReminder.JobScheduler.UnitTests/InvoiceReminder.JobScheduler.UnitTests.csproj
grep -E "<PackageReference.*Analyzer"            -n InvoiceReminder.JobScheduler.UnitTests/InvoiceReminder.JobScheduler.UnitTests.csproj

Length of output: 1713


Atualizar o SDK do projeto para 3.9.3

Para manter a compatibilidade com os pacotes MSTest.TestFramework, MSTest.TestAdapter e MSTest.Analyzers (todos na versão 3.9.3), atualize o atributo Sdk no arquivo de teste:

• Arquivo: InvoiceReminder.JobScheduler.UnitTests/InvoiceReminder.JobScheduler.UnitTests.csproj
• Linha: 1

-<Project Sdk="MSTest.Sdk/3.6.4">
+<Project Sdk="MSTest.Sdk/3.9.3">
🤖 Prompt for AI Agents
In
InvoiceReminder.JobScheduler.UnitTests/InvoiceReminder.JobScheduler.UnitTests.csproj
at line 1, update the Project Sdk attribute from "MSTest.Sdk/3.6.4" to
"MSTest.Sdk/3.9.3" to ensure compatibility with MSTest.TestFramework,
MSTest.TestAdapter, and MSTest.Analyzers packages version 3.9.3.


<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
Expand All @@ -13,30 +13,30 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.14.1" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.CodeCoverage" Version="17.14.2" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.6.3" />
<PackageReference Update="Microsoft.Testing.Extensions.TrxReport" Version="1.7.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.Analyzers" Version="3.8.3">
<PackageReference Update="MSTest.Analyzers" Version="3.9.3">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestAdapter" Version="3.8.3" />
<PackageReference Update="MSTest.TestAdapter" Version="3.9.3" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="MSTest.TestFramework" Version="3.8.3" />
<PackageReference Update="MSTest.TestFramework" Version="3.9.3" />
</ItemGroup>

<ItemGroup>
Expand Down