Skip to content

Add VTK support for cases where rd.N is a tuple with all equal values#197

Merged
jlchan merged 2 commits intojlchan:mainfrom
tristanmontoya:vtk_support_tuple_polynomial_degree
Aug 9, 2025
Merged

Add VTK support for cases where rd.N is a tuple with all equal values#197
jlchan merged 2 commits intojlchan:mainfrom
tristanmontoya:vtk_support_tuple_polynomial_degree

Conversation

@tristanmontoya
Copy link
Copy Markdown
Contributor

@tristanmontoya tristanmontoya commented Apr 19, 2025

This is needed for visualizing prism meshes with trixi-framework/Trixi2Vtk.jl#103, which calls SUD_to_vtk_order.

@jlchan
Copy link
Copy Markdown
Owner

jlchan commented Aug 9, 2025

Woah, sorry I missed this for so long! Let me just run CI and if it works I'll merge immediately.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 9, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.05%. Comparing base (86aa5ab) to head (5c6dd7b).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/mesh/vtk_helper.jl 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   95.94%   95.05%   -0.89%     
==========================================
  Files          28       28              
  Lines        3846     3926      +80     
==========================================
+ Hits         3690     3732      +42     
- Misses        156      194      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlchan jlchan merged commit 2742fb1 into jlchan:main Aug 9, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants