Fix ~60 UI and backend bugs: signal bindings, null safety, infinite recursion, filter logic#230
Draft
Copilot wants to merge 2 commits into
Draft
Fix ~60 UI and backend bugs: signal bindings, null safety, infinite recursion, filter logic#230Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/jjasloot/OVDB/sessions/832ec11d-00e3-4940-8875-5a2cac43dc15 Co-authored-by: jjasloot <5612709+jjasloot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jjasloot/OVDB/sessions/47d1a7da-83eb-4671-8ba8-2c454b2fdaf3 Co-authored-by: jjasloot <5612709+jjasloot@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jjasloot
May 15, 2026 12:56
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the full bug inventory from
BUGS.md— logic errors, broken UI bindings, null crashes, memory leaks, and unsafe backend patterns.Critical Logic Fixes
filter += filter += ...→filter += ...queryParams.has("from")→has("to")—todate was silently ignoredthis.bounds = ...→this._bounds = ...from == null→to == nullinsetApplicableFilterBroken UI Bindings (buttons/toggles not working)
[(ngModel)]on Angular signals doesn't work — the signal reference is bound instead of its value. All four affected bindings inroute-instances-edit:Same pattern applied to
enterScheduledTimes,endTimeDayOffset(mat-select), andselectedMaps(mat-selection-list).Also fixed
!this.maps/!this.countries→!this.maps()/!this.countries()in route-detail (always evaluated falsy).Auth / Security
****** header**: interceptor now only setsAuthorization` when token is non-nulldecodeToken(null)crash: guarded inemailandadmingetters;adminnow accepts both"true"string and booleanisLoggedInbeforeadmin'/' + url.join('/')produced//for empty segmentsSignalR
Added
connectingflag to prevent duplicate WebSocket connections during rapidconnect()calls. Event handlers now registered before.start().Memory Leaks
Applied
takeUntilDestroyed()to unmanaged subscriptions in:map,single-route-map,countries,time-stats,wizard-step2. AddedngOnDestroytoprofileto clear the OAuth polling interval; added null-check onwindow.open()(popup blocked case).Null Safety
table()?.renderRows()in route-instances-editmapsSelection()null-guard before.selectedOptionsin route-detailfeature.propertiesandlayer.getPopup()guards in single-route-mapconnectionStatus?.user?.displayNamein traewelling templatedata = []initialization in countries and image-creator; error handlers addedBackend (C#)
SingleOrDefault(...).Value→SingleOrDefault(...)?.Value(NullReferenceException when claim absent).Single()→.SingleOrDefaultAsync()+ null check forGetRoute; KML import.Single()→.FirstOrDefault()dbMapbefore property assignment inPutMap