routine: event-tool-parameters (2026-05-29)#22
Draft
jim4226 wants to merge 1 commit into
Draft
Conversation
Claude Code v2.1.157 added tool_parameters to OTEL tool_decision events so that bash commands, MCP tool names, and skill URIs are auditable at the call-site rather than buried inside a generic payload dict. CSIS's EventLog carries the same semantic gap. Adds an optional tool_parameters field (dict | None, default None) to Event and a matching keyword arg to emit(). All existing callers are unchanged. Existing JSONL files without the field deserialize with None (Pydantic default — backward compat regression test added). Touches: csis/substrate/event_log.py (Event model + emit signature) Tests: 2 new in tests/test_substrate.py (round-trip + legacy compat)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tool_parameters: dict[str, Any] | None = NonetoEventincsis/substrate/event_log.pyand a matching keyword arg toemit(), mirroring thetool_parametersfield shipped in Claude Code v2.1.157 fortool_decisionOTEL events.Source
tool_decisionevents now includetool_parameters(bash commands, MCP/skill names) whenOTEL_LOG_TOOL_DETAILS=1"Theme
Theme 2 — Trust + verification. CSIS's Auditor reads the
EventLogto construct the why-doc that gates every promotion. When the Coordinator (or a future Tool Execution primitive in P1.7) emits atool_decisionevent, the Auditor currently sees only the genericpayloaddict — the tool's parameters are not structurally distinct from other event data. Adding a dedicatedtool_parametersfield gives the Auditor a clear schema path to query which tool was called with which arguments, enabling grader drift detection and exfiltration audits to operate on tool-call evidence, not inferred payload shapes.What changed
csis/substrate/event_log.pyEventgainstool_parameters: dict[str, Any] | None = Field(default=None, ...).emit()gains*, tool_parameters: dict[str, Any] | None = Nonekeyword arg. All existing call sites are unchanged.tests/test_substrate.pyNonedefault (backward compat guard).No cycle-9 chokepoints touched
Eventis a leaf Pydantic model.Coordinator.__init__,_BackendTracker,writer_iteration_id, and the promotion CAS are all untouched. The defaulttool_parameters=Nonemeans every existingemit()call is semantically unchanged.Test plan
Generated by Claude Code