Use is-buffer module to reduce bundle size.#1
Open
michaelrhodes wants to merge 1 commit intojhiesey:masterfrom
Open
Use is-buffer module to reduce bundle size.#1michaelrhodes wants to merge 1 commit intojhiesey:masterfrom
michaelrhodes wants to merge 1 commit intojhiesey:masterfrom
Conversation
Owner
|
When would you use Also, I should be able to remove the |
jimmywarting
added a commit
to jimmywarting/to-arraybuffer
that referenced
this pull request
Jul 9, 2021
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, thanks for writing this module! I’m pretty sensitive about browserify bundle sizes, so I thought I’d point out that you can yield quite a substantial saving by swapping out
Buffer.isBufferfor feross/is-buffer (see below).