Fix: rawHeaders array access bug causing incorrect charset detection#127
Open
liorcode wants to merge 1 commit intojhiesey:masterfrom
Open
Fix: rawHeaders array access bug causing incorrect charset detection#127liorcode wants to merge 1 commit intojhiesey:masterfrom
liorcode wants to merge 1 commit intojhiesey:masterfrom
Conversation
- Replace object access `rawHeaders['mime-type']` with the headers object - Change header lookup from 'mime-type' to 'content-type' (HTTP standard) - Fix regex to capture multi-character charset values ([^;]+) - Add test case to verify charset extraction from content-type header
Author
|
@jhiesey not sure you still maintain this project, can you review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rawHeaders['mime-type']with the headers object