Open
Conversation
The old check looked at both `host` and `hostname`, which was prone to errors for multiple reasons: - `host` could include `:` but be ipv4 - ipv6 could already have square brackets, which produced invalid URIs like `http://[[::1]]:80` This changes ipv6 normalization to only run if `hostname` parameter is provided and does not start with `[`. Also, added missing tests for ipv6. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old check effectively merged the meaning of
hostandhostname, which was prone toerrors:
hostcould include:but be ipv4 with a custom port (eg.127.0.0.1:8080) which would produce false-positives[::1]– see the end of this comment), but normalization would run anyway and produced invalid URIs likehttp://[[::1]]:80This changes ipv6 normalization to only run if actual
hostnameparameter isprovided, includes
:and does not start with[. Also, added missing tests for ipv6.cc #18, ipfs/ipfs-companion#668