Open
Conversation
Owner
|
Curious as to what’s the use case here. |
Author
|
Currently, you can only check one item at a time. This PR effectively decompresses the bloom filter and turns it into a set. Specifically for me, it means I can filter a Pandas DataFrame using its internal For example: f = UIntBloomFilter.from_base64(b64.encode('ascii'))
_, uniques = f.uniques_in_range(0, df.id.max())
flags = df.id.isin(uniques)...which is 10x faster than doing things item-by-item: f = UIntBloomFilter.from_base64(b64.encode('ascii'))
flags = [idx in f for idx in df.id]Not sure if this actually merits merging upstream. If it's not, no worries, figured I'd contribute since I had it around anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard
containsfunction in pybloof checks for a single element. If you'd like to check a range of elements, this is python-limited and slow, so this PR is for a cythonized "range contains".