This repository was archived by the owner on May 15, 2018. It is now read-only.
Let stdout/stderr be configurable#16
Open
andreastt wants to merge 2 commits intojgraham:masterfrom
andreastt:expose-stdio
Open
Let stdout/stderr be configurable#16andreastt wants to merge 2 commits intojgraham:masterfrom andreastt:expose-stdio
andreastt wants to merge 2 commits intojgraham:masterfrom
andreastt:expose-stdio
Conversation
It does not necessarily make sense to expose build_command on the FirefoxRunner trait. As I understand it the function should be an internal implementation detail as you would not have any need for constructing the command externally.
Contributor
Author
|
r? @jgraham |
Contributor
Author
|
FWIW I cannot help but feel that the API could of this crate could be improved by using a builder-style approach. This would let the caller construct the appropriate |
Contributor
Author
|
Prerequisite for https://bugzilla.mozilla.org/show_bug.cgi?id=1399441. |
Contributor
Author
|
Ping @jgraham |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately
std::process::Stdiodoes not implementCopyorCloneso it can’t be stored in our struct. The only option I could find was to provide variations through a custom enum that we construct the appropriatestd::process::Stdiostruct from. I’m not sure if there’s a better option?This change is