Skip to content

Fix: hierarchy click should only open Class definition, not the source file#140

Open
MatiasFernandez wants to merge 2 commits into
mainfrom
mfernandez.fix-hierarchy-file-open
Open

Fix: hierarchy click should only open Class definition, not the source file#140
MatiasFernandez wants to merge 2 commits into
mainfrom
mfernandez.fix-hierarchy-file-open

Conversation

@MatiasFernandez

Copy link
Copy Markdown
Collaborator

Summary

Clicking a class in the System Browser's hierarchy view opened both the Class Definition panel and the on-disk .gs Topaz cache file for that class. This shoved a redundant read-only tab in front of whatever the user was actively editing. The column-view click already only opened the definition — the hierarchy click should behave the same way.

Changes

  • Removed the extra openClassFile call from the hierarchy-click handler in client/src/systemBrowser.ts, so it now only calls applyClassSelection, matching column-click behavior.
  • Updated surrounding comments to reflect that both the column click and hierarchy click are definition-only.
  • Added a regression test in client/src/__tests__/systemBrowser.test.ts asserting that selecting a hierarchy class does not trigger showTextDocument.

Addresses Gitlab#36.

Test plan

  • npm run compile && npm test passes
  • Manually tested in the extension: clicking a class in the hierarchy view now only opens/refreshes the Class Definition panel and no longer opens a redundant source file tab, confirming the fix works as intended.

@MatiasFernandez MatiasFernandez marked this pull request as ready for review July 3, 2026 20:03
@MatiasFernandez MatiasFernandez requested a review from npapagna July 3, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant