Fix: hierarchy click should only open Class definition, not the source file#140
Open
MatiasFernandez wants to merge 2 commits into
Open
Fix: hierarchy click should only open Class definition, not the source file#140MatiasFernandez wants to merge 2 commits into
MatiasFernandez wants to merge 2 commits into
Conversation
…iew should only open the Class definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking a class in the System Browser's hierarchy view opened both the Class Definition panel and the on-disk
.gsTopaz cache file for that class. This shoved a redundant read-only tab in front of whatever the user was actively editing. The column-view click already only opened the definition — the hierarchy click should behave the same way.Changes
openClassFilecall from the hierarchy-click handler inclient/src/systemBrowser.ts, so it now only callsapplyClassSelection, matching column-click behavior.client/src/__tests__/systemBrowser.test.tsasserting that selecting a hierarchy class does not triggershowTextDocument.Addresses Gitlab#36.
Test plan
npm run compile && npm testpasses