Skip to content

ci: version of node to install #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johngeorgewright merged 1 commit into from
Jun 7, 2026
+8 −8
Merged

ci: version of node to install #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/actions/install/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ name: Install

description: Installs node and dependencies

inputs:
node-version:
description: 'Version Spec of the version to use. Examples: 12.x, 10.15.1, >=10.15.0.'
required: true

runs:
using: composite
steps:
Expand Down
5 changes: 0 additions & 5 deletions .github/actions/test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ name: Test

description: Build & Test

inputs:
node-version:
description: 'Version Spec of the version to use. Examples: 12.x, 10.15.1, >=10.15.0.'
required: true

runs:
using: composite
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
steps:
- uses: actions/checkout@v6
- uses: ./.github/actions/install
- uses: ./.github/actions/test
with:
node-version: ${{ matrix.node-version }}
- uses: ./.github/actions/test
- id: nvm
run: echo "version=$(cat .nvmrc)" >> $GITHUB_OUTPUT
- uses: actions/upload-artifact@v7
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
with:
cache: yarn
node-version-file: .nvmrc
registry-url: 'https://registry.npmjs.org'
registry-url: "https://registry.npmjs.org"
- run: yarn --immutable
- uses: actions/download-artifact@v8
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ jobs:
steps:
- uses: actions/checkout@v6
- uses: ./.github/actions/install
- uses: ./.github/actions/test
with:
node-version: ${{ matrix.node-version }}
- uses: ./.github/actions/test