fix: honor --skip-login on docker build#3396
fix: honor --skip-login on docker build#3396joergsesterhenn wants to merge 1 commit intojfrog:masterfrom
Conversation
|
fixes #3397 |
7e19f50 to
c0a17dd
Compare
|
I have read the CLA Document and I hereby sign the CLA |
fluxxBot
left a comment
There was a problem hiding this comment.
fix looks good, but need to update (if any) or add test related to this fix!
|
I'm not a go developer. Just a customer who wants this broken code fixed ASAP. The developer who introduced this buggy code in the first place didn't bother to test his code and broke our use of this tool, so I appreciate your feedback. If you can, please add tests and release a fixed version. |
|
Thanks, @joergsesterhenn for your work here! |
This issue is fixed already in the current version. The devs created a new PR and added some tests. |
|
Thank you. I noticed it worked for us. Maybe we should close this PR then. |

masterbranch.go vet ./....go fmt ./....