Product and manufacturer descriptors#260
Closed
alextrical wants to merge 4 commits intojfedor2:masterfrom
Closed
Conversation
Contributor
Author
|
One step towards making the work in #250 able to be usable in main. |
Contributor
Author
|
closed in favour of #346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dymanic manufacturer and product names, that can be set through the product descriptor.
Added the matching Product and Manufacturer names to the existing descriptors
Ive only just spotted that you may not be accepting PR's at the moment, so please feel free to close this, if you don't need the hastle at the moment