[WAIT FOR COOLDOWN PERIOD] enable push triggers for desktop publish workflows#1793
Draft
paustint wants to merge 1 commit into
Draft
[WAIT FOR COOLDOWN PERIOD] enable push triggers for desktop publish workflows#1793paustint wants to merge 1 commit into
paustint wants to merge 1 commit into
Conversation
paustint
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Enables automatic execution of the macOS and Windows desktop publish GitHub Actions workflows when desktop-v* tags are pushed, instead of requiring manual dispatch. This supports a more automated desktop release pipeline that can be driven by the main release.yml workflow.
Changes:
- Enable
on.push.tags: desktop-v*triggers for both desktop publish workflows. - Remove
environment: productionfrom both desktop publish jobs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| .github/workflows/publish-desktop-windows.yml | Enables tag-based triggering for Windows desktop publishing and removes the production environment binding. |
| .github/workflows/publish-desktop-macos.yml | Enables tag-based triggering for macOS desktop publishing and removes the production environment binding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paustint
force-pushed
the
chore/auto-publish-desktop-artifacts
branch
from
0bfe835 to
0750bfb
Compare
Comment on lines
28
to
33
| jobs: | ||
| build-windows: | ||
| runs-on: windows-latest | ||
| timeout-minutes: 60 | ||
| environment: production | ||
| env: | ||
| NODE_OPTIONS: "--max_old_space_size=8192" |
Comment on lines
28
to
33
| jobs: | ||
| build-macos: | ||
| runs-on: macos-latest | ||
| timeout-minutes: 60 | ||
| environment: production | ||
| env: | ||
| NODE_OPTIONS: "--max_old_space_size=8192" |
Comment on lines
184
to
200
| publish: | ||
| ENV.IS_CODESIGNING_ENABLED && ENV.AWS_ACCESS_KEY_ID && ENV.AWS_SECRET_ACCESS_KEY | ||
| ENV.IS_CODESIGNING_ENABLED && ENV.AWS_ACCESS_KEY_ID && ENV.AWS_SECRET_ACCESS_KEY && ENV.AWS_ENDPOINT_URL | ||
| ? [ | ||
| // Primary feed clients read from — a subdomain we control, decoupled from any | ||
| // storage vendor. Backed by Backblaze today, Cloudflare R2 after the DNS cutover. | ||
| // storage vendor. Backed by Cloudflare R2. | ||
| { | ||
| provider: 'generic', | ||
| url: 'https://release-updates.getjetstream.app/jetstream/releases', | ||
| }, | ||
| // Upload target during the sunset: keep publishing to Backblaze so existing clients | ||
| // (pinned to the raw B2 endpoint in their baked app-update.yml) keep updating. | ||
| { | ||
| provider: 's3', | ||
| // Local testing with MinIO | ||
| // endpoint: 'http://localhost:9000', | ||
| endpoint: 'https://s3.us-east-005.backblazeb2.com', | ||
| endpoint: ENV.AWS_ENDPOINT_URL, | ||
| bucket: 'desktop-updates', | ||
| path: `jetstream/releases`, | ||
| region: 'auto', | ||
| acl: null, | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows users have broken updates since the CN name change on the certificate (it is case-sensitive)
This PR shuold wait to merge for 7-10 days so that dekstop users can reasonably install the latest version where the failed update can include instructions to re-install