Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Paramaterstore#1

Open
jmahowald wants to merge 2 commits intojetstack:masterfrom
code42:parameterstore
Open

Paramaterstore#1
jmahowald wants to merge 2 commits intojetstack:masterfrom
code42:parameterstore

Conversation

@jmahowald
Copy link
Copy Markdown

AWS Parameter Store (SSM) has native support for "SecureString" types. This ends up being easier to integrate in to get the actual root token if another process needs it for vault provisioning. I debated changing just the actual logic of the KMS store, but figured it's less impactful downstream if I just created a new mode.

@simonswine simonswine self-assigned this Nov 16, 2017
@simonswine
Copy link
Copy Markdown
Contributor

Thanks for your PR @jmahowald. Sorry that it took a while. I am having this issue when I am trying to run the CI tests: (Sorry these are not yet publicly accessible)

FAIL    github.com/jetstack/vault-unsealer/pkg/kv/aws_param     0.894s
--- FAIL: TestAWSIntegration (0.69s)
        aws_ssm_test.go:55: Unexpected error storing value in SSM kv: key '%s' not found
        aws_ssm_test.go:59: Unexpected decrypt output: exp=payload123 act=

@danaps
Copy link
Copy Markdown

danaps commented Jan 15, 2018

@jmahowald tried your branch, it works perfectly with parameters store.

@davidholsgrove
Copy link
Copy Markdown

+1 for using SecureStrings without any base64 encoding in parameter store.
@simonswine - can we help get this merged?

@raoofm
Copy link
Copy Markdown

raoofm commented Jun 21, 2018

@simonswine is this being tracked?

@raoofm
Copy link
Copy Markdown

raoofm commented Jun 21, 2018

/cc @munnerz

@jetstack-bot jetstack-bot requested a review from munnerz June 21, 2018 19:33
@jetstack-bot
Copy link
Copy Markdown
Collaborator

@jmahowald: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants