This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Paramaterstore#1
Open
jmahowald wants to merge 2 commits intojetstack:masterfrom
code42:parameterstore
Open
Conversation
added 2 commits
October 17, 2017 23:49
…act directly with parameter store
Contributor
|
Thanks for your PR @jmahowald. Sorry that it took a while. I am having this issue when I am trying to run the CI tests: (Sorry these are not yet publicly accessible) |
|
@jmahowald tried your branch, it works perfectly with parameters store. |
|
+1 for using SecureStrings without any base64 encoding in parameter store. |
|
@simonswine is this being tracked? |
|
/cc @munnerz |
Collaborator
|
@jmahowald: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS Parameter Store (SSM) has native support for "SecureString" types. This ends up being easier to integrate in to get the actual root token if another process needs it for vault provisioning. I debated changing just the actual logic of the KMS store, but figured it's less impactful downstream if I just created a new mode.