Skip to content

Conversation

@jetelain
Copy link
Owner

@jetelain jetelain commented Mar 29, 2025

Some users have lost their map source after moving to a new computer or after reinstaling windows.

This feature aims to restore most edit features from a generated mod.

@jetelain jetelain requested a review from Copilot April 5, 2025 15:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 20 changed files in this pull request and generated 1 comment.

Files not reviewed (4)
  • GameRealisticMap.Studio/Labels.Designer.cs: Language not supported
  • GameRealisticMap.Studio/Labels.fr.resx: Language not supported
  • GameRealisticMap.Studio/Labels.resx: Language not supported
  • GameRealisticMap.Studio/Modules/Arma3WorldEditor/Views/Arma3WorldEditorView.xaml: Language not supported
Comments suppressed due to low confidence (2)

GameRealisticMap.Studio/Modules/Arma3WorldEditor/ViewModels/MaterialItem.cs:32

  • The condition checking if 'textures.Count == 0' appears inverted compared to the previous behavior that checked for textures.Count > 0. Please verify that this logic change is intentional.
if (textures.Count == 0)

GameRealisticMap.Studio/Modules/Arma3WorldEditor/ViewModels/Arma3WorldEditorViewModel.cs:287

  • [nitpick] Notifying a change for the property 'Imagery' from within the GrmImagery setter can be confusing since 'Imagery' is computed from GrmImagery and GenericImagery. Consider revising the naming or clarification of property dependencies.
NotifyOfPropertyChange(nameof(Imagery));


public Task<Image<TPixel>?> LoadImagePart<TPixel>(int partId)
where TPixel : unmanaged, IPixel<TPixel>
{
Copy link

Copilot AI Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing an element using 'partId-1' assumes that the part IDs are 1-based and that the index will always be within bounds. Please add a validation to ensure 'partId' is valid to prevent potential out-of-range errors.

Suggested change
{
{
if (partId < 1 || partId > partitioner.OtherTileInfos.Count)
{
throw new ArgumentOutOfRangeException(nameof(partId), "partId must be within the valid range.");
}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants