perf: skip untracked file enumeration when staging hunks of tracked files#5466
Closed
renezander030 wants to merge 1 commit intojesseduffield:masterfrom
Closed
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
…iles When staging hunks in the staging panel, lazygit refreshes the files list by running git status --untracked-files=all. In large repos (e.g. 275k files) this directory walk dominates the refresh time, causing multi-second delays after each staging operation. Since staging hunks of a tracked file cannot change the set of untracked files, we can safely skip their enumeration by using --untracked-files=no and preserving the untracked files from the previous model state. The optimization is only applied when the file being staged is tracked. Staging an untracked file (status ??) still triggers a full refresh to correctly capture the ?? to AM transition. Fixes jesseduffield#5455
renezander030
force-pushed
the
perf/skip-untracked-on-staging-refresh
branch
from
f89d6e9 to
25cced3
Compare
Collaborator
|
I'm not interested in reviewing AI generated PRs. Closing. |
Author
|
Understood. For what it's worth, the fix came from debugging a real performance issue I hit while using lazygit on a large monorepo. But I respect the policy. Thanks for maintaining the project! |
Collaborator
|
In this case you might try this PR and see if it helps with your monorepo. Please report your findings. I'd also be interested in your answer to this question because I haven't been able to reproduce the issue myself with various large test repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git status --untracked-files=allruns on every refresh. In large repos (275k+ files) this causes multi-second delays after each staging operation.--untracked-files=noand preserving untracked files from the previous model state.??) still triggers a full refresh to capture the??>AMtransition correctly.Test plan
go build ./...compilesgo test ./pkg/commands/git_commands/... ./pkg/gui/...passesAMcorrectlyFixes #5455